Skip to content

Feat: channel different comm managers #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lterrac merged 13 commits into from
Oct 3, 2025
Merged

Feat: channel different comm managers #46

lterrac merged 13 commits into from
Oct 3, 2025

Conversation

@lterrac
Copy link
Collaborator

@lterrac lterrac commented Oct 1, 2025 •
edited
Loading

Description

  • channels now require separate communication manager for coordination buffers and payloads
  • fix pthreads communication manager to keep exchanged global memory slots up to date
  • add pthreads channels examples
  • fix object store example
  • add missing docs

Type of change

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

@lterrac lterrac force-pushed the feat/channelDifferentCommManagers branch from 6b2f818 to 0f7cff7 Compare October 2, 2025 12:59
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Coverage arm64

Code Coverage

Package Line Rate Branch Rate Health
include.hicr.backends.boost 75% 43% ➖
include.hicr.backends.hwloc 76% 37% ➖
include.hicr.backends.mpi 96% 53% ✔
include.hicr.backends.nosv 71% 45% ➖
include.hicr.backends.pthreads 89% 49% ✔
include.hicr.core 72% 45% ➖
include.hicr.frontends.RPCEngine 100% 48% ✔
include.hicr.frontends.channel 95% 64% ✔
include.hicr.frontends.channel.fixedSize 100% 50% ✔
include.hicr.frontends.channel.fixedSize.mpsc.locking 92% 65% ✔
include.hicr.frontends.channel.fixedSize.mpsc.nonlocking 94% 55% ✔
include.hicr.frontends.channel.fixedSize.spsc 95% 68% ✔
include.hicr.frontends.channel.variableSize 92% 50% ✔
include.hicr.frontends.channel.variableSize.mpsc.locking 84% 50% ✔
include.hicr.frontends.channel.variableSize.mpsc.nonlocking 95% 48% ✔
include.hicr.frontends.channel.variableSize.spsc 91% 54% ✔
include.hicr.frontends.objectStore 63% 41% ➖
include.hicr.frontends.tasking 80% 56% ✔
Summary 83% (1876 / 2260) 48% (1120 / 2351) ✔

Minimum allowed line rate is 60%

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Coverage amd64

Code Coverage

Package Line Rate Branch Rate Health
include.hicr.backends.boost 75% 43% ➖
include.hicr.backends.hwloc 76% 37% ➖
include.hicr.backends.mpi 96% 53% ✔
include.hicr.backends.nosv 71% 45% ➖
include.hicr.backends.pthreads 89% 49% ✔
include.hicr.core 72% 45% ➖
include.hicr.frontends.RPCEngine 100% 49% ✔
include.hicr.frontends.channel 95% 64% ✔
include.hicr.frontends.channel.fixedSize 100% 50% ✔
include.hicr.frontends.channel.fixedSize.mpsc.locking 92% 65% ✔
include.hicr.frontends.channel.fixedSize.mpsc.nonlocking 96% 57% ✔
include.hicr.frontends.channel.fixedSize.spsc 95% 68% ✔
include.hicr.frontends.channel.variableSize 90% 50% ✔
include.hicr.frontends.channel.variableSize.mpsc.locking 84% 50% ✔
include.hicr.frontends.channel.variableSize.mpsc.nonlocking 95% 48% ✔
include.hicr.frontends.channel.variableSize.spsc 91% 54% ✔
include.hicr.frontends.objectStore 63% 41% ➖
include.hicr.frontends.tasking 80% 56% ✔
Summary 83% (1874 / 2257) 48% (1120 / 2347) ✔

Minimum allowed line rate is 60%

@lterrac lterrac merged commit 05e9a33 into master Oct 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lterrac